[CA-572] remove shallow permissions checks #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctalbott
changed the title
dvoet
approved these changes
Apr 17, 2020
| } yield { | ||
| attempt2 | ||
| } | ||
| traceIOWithParent("fullCheck", parentSpan)(_ => hasPermissionFullCheck(resource, action, userId)) |
There was a problem hiding this comment.
I would rename hasPermissionFullCheck to hasPermission and remove this method
gpolumbo-broad
approved these changes
Apr 17, 2020
marctalbott
force-pushed
the
mtalbott-long-circuit
branch
from
e5a002f
to
6b1e45a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CA-572
The performance benefit of the short-circuit approach no longer appears to exist in our new Postgres world. This PR removes the short circuit for cleanliness.
See performance results here if curious: https://datastudio.google.com/open/1BpuL1fTAEmmwsCzCzUm2M-tCygIG1Tcm?usp=sharing
PR checklist