Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CA-925] add listResourceChildren endpoint #443

Merged
merged 4 commits into from
Jul 30, 2020
Merged

[CA-925] add listResourceChildren endpoint #443

merged 4 commits into from
Jul 30, 2020

Conversation

marctalbott
Copy link
Contributor

Ticket: CA-925

  • Add endpoint to Sam to list direct children of a resource

PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

@marctalbott
add listResourceChildren
1f64af4 
add routes tests, update swagger, rename FQResourceId json formatter for consistency

fix typo

change from all descendents to only direct children
marctalbott
marctalbott commented Jul 22, 2020
View reviewed changes
src/main/scala/org/broadinstitute/dsde/workbench/sam/model/SamModel.scala
@@ -38,7 +38,7 @@ object SamJsonSupport {

implicit val ResourceIdFormat = ValueObjectFormat(ResourceId.apply)

implicit val ResourceIdentityFormat = jsonFormat2(FullyQualifiedResourceId.apply)
implicit val FullyQualifiedResourceIdFormat = jsonFormat2(FullyQualifiedResourceId.apply)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to rest of PR, just noticed that this json formatter was named inconsistently

@coveralls
Copy link

coveralls commented Jul 22, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 76.576% when pulling 2aa5eb2 on mtalbott-list-direct-children into 9244fb8 on develop.

@marctalbott @gpolumbo-broad
fix typo
2aa5eb2 
Co-authored-by: Greg Polumbo <36171087+gpolumbo-broad@users.noreply.github.com>
@marctalbott marctalbott merged commit aaa97da into develop Jul 30, 2020
@marctalbott marctalbott deleted the mtalbott-list-direct-children branch July 30, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoet dvoet dvoet approved these changes

@gpolumbo-broad gpolumbo-broad gpolumbo-broad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marctalbott @coveralls @dvoet @gpolumbo-broad