CA-1176 allow children to be deleted without remove_child on parent #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoet
commented
Feb 8, 2021
| @@ -411,6 +411,43 @@ class ResourceRoutesV2Spec extends AnyFlatSpec with Matchers with TestSupport wi | |||
| } | |||
| } | |||
|
|
|||
| it should "204 deleting a child resource" in { | |||
There was a problem hiding this comment.
this test was moved from below and amended not to require the remove_child action
dvoet
commented
Feb 8, 2021
| } | ||
| } | ||
|
|
||
| it should "400 when attempting to delete a resource with children" in { |
There was a problem hiding this comment.
this test was moved from below (it was in the wrong place)
dvoet
commented
Feb 8, 2021
| } | ||
| } | ||
|
|
||
| it should "403 if user is missing remove_child on parent resource if it exists" in { |
There was a problem hiding this comment.
this test was removed
dvoet
commented
Feb 8, 2021
| @@ -1395,39 +1432,6 @@ class ResourceRoutesV2Spec extends AnyFlatSpec with Matchers with TestSupport wi | |||
| } | |||
| } | |||
|
|
|||
| "DELETE /api/resources/v2/{resourceTypeName}/{resourceId}" should "204 on a child resource if the user has remove_child on the parent resource" in { | |||
dvoet
commented
Feb 8, 2021
| @@ -1482,26 +1486,6 @@ class ResourceRoutesV2Spec extends AnyFlatSpec with Matchers with TestSupport wi | |||
| } | |||
| } | |||
|
|
|||
| it should "400 when attempting to delete a resource with children" in { | |||
dvoet
changed the title
andy7i
approved these changes
Feb 8, 2021
| requireParentAction(resource, None, SamResourceActions.removeChild, userInfo.userId, samRequestContext) { | ||
| complete(resourceService.deleteResource(resource, samRequestContext).map(_ => StatusCodes.NoContent)) | ||
| } | ||
| complete(resourceService.deleteResource(resource, samRequestContext).map(_ => StatusCodes.NoContent)) |
There was a problem hiding this comment.
I think it would be helpful to leave a comment about why we are intentionally not requiring removeChild here.
| @@ -411,6 +411,43 @@ class ResourceRoutesV2Spec extends AnyFlatSpec with Matchers with TestSupport wi | |||
| } | |||
| } | |||
|
|
|||
| it should "204 deleting a child resource" in { | |||
gpolumbo-broad
approved these changes
Feb 8, 2021
|
jenkins retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/CA-1176
PR checklist