[CA-1327] Github Actions #521
Conversation
|
I will make the Travis CI piece not required, and make the GHA required before merging, just that is a repo-wide setting so wanted to wait for approvals before futzing with it. |
|
could you add a bit more details about the PR: any differences between travis vs GHA that we should know about? (also, I think we're required to have a ticket # for each PR now) |
s-rubenstein
changed the title
|
Yes, thank you. Forgot to update the title after requesting review. The big differences between GHA and Travis are:
|
.github/workflows/build.yml
Outdated
| id: tests | ||
| run: sbt clean "testOnly -- -n org.broadinstitute.tags.SchemaInit" | ||
|
|
||
| - name: Generate coverage report |
There was a problem hiding this comment.
nit: this runs the unit tests and generates the coverage report
.github/workflows/build.yml
Outdated
| ./minnie-kenny.sh --force | ||
| git secrets --scan-history | ||
|
|
||
| - name: Integration tests |
There was a problem hiding this comment.
nit: these aren't integration tests, this command just runs the tests tagged with SchemaInit. Maybe rename to 'Run JndiSchemaInit tests' or something like that
There was a problem hiding this comment.
Sure, can rename.
.github/workflows/build.yml
Outdated
|
|
||
| - name: Publish java client for merge | ||
| working-directory: codegen_java | ||
| id: publishJavaClientSnapshot |
There was a problem hiding this comment.
nit: the ids are swapped, this one isn't a snapshot
| - bash scripts/gen_java_client.sh | ||
| after_success: | ||
| - export SBT_OPTS="-J-Xmx3g" | ||
| - sbt coveralls |
There was a problem hiding this comment.
i think we can remove this dependency
Line 5 in c34ff18
Co-authored-by: Andrew <andy7i@users.noreply.github.com>
Ticket:
PR checklist