Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX compatibility #374

Merged
merged 15 commits into from
Jun 23, 2016
Merged

OSX compatibility #374

merged 15 commits into from
Jun 23, 2016

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Jun 23, 2016

This makes the test suite pass on OSX, mostly by skipping a few of the ones that depend on Kraken, Diamond, or VPhaser2. It prepares some aspects of Travis testing, but does not actually enable them because of slow boot-up and build times in their current infrastructure.

@tomkinsc
Copy link
Member

I suppose this means I can delete my enable-osx-builds branch from a while ago? It was mostly working, albeit with 3x longer test time and often significant delays in the Travis queue waiting for OSX build slots to be available.

@dpark01
Copy link
Member Author

dpark01 commented Jun 23, 2016

Yeah, I copied a lot of snippets straight out of your branch actually. I mostly got mine working, with the exception of coveralls I think... but I also noticed that the queue wait times and actual build times meant that I really didn't want to wait around for OSX builds on the average PR for this project. But I figured we might as well make it so that devs can successfully py.test everything on their local machines and start putting some of the travis infrastructure in place.

@dpark01 dpark01 merged commit 7d8d930 into master Jun 23, 2016
@dpark01 dpark01 deleted the dp-osx branch June 23, 2016 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants