New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mlin's new demux launcher #838
Conversation
This reverts commit 037cf6b.
Is this a non-deterministic Travis test failure? (pasting it here for future reference in case the error disappears on re-run).
|
…Seq runs, change demux_outputs class to array:file
demux_instance_type="mem1_hdd2_x32" | ||
min_base_quality=25 | ||
echo "Detected $total_tile_count tiles, interpreting as HiSeq4k run, executing on a $demux_instance_type machine." | ||
elif [ "$total_tile_count" -le 1408 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had noticed a while ago that I've had difficulty getting hdd2
AWS/DX instances to run. @mlin can you confirm if these are being phased out? Should we stick to ssd2
instances instead?
Note for future reference... that Travis failure was indeed non-deterministic. I'm not exactly sure how "No such file or directory: 'libgkl_compression2251932993111688424.so'" could possibly be non-deterministic, but ... something to keep an eye on. I'll open an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once any remaining technical items are sorted out and the whole system has been hand-tested on dx with a few different flowcell sizes (miseq, hs2500rr, nova), these changes look good from a review standpoint.
…ute/viral-ngs into ct-mlin-demux-launcher
This is a branch off @mlin's branch proposed in #809. It adds an applet title so the launcher job includes more than just the run_id in its title. It also adds auto-scaling, currently commented out as the instance type passed to dx run seems to propagate to override instance types specified in individual tasks. The L# directories are now placed below
reads/
.