Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ncbi tbl parser for refseq accessions #899

Merged
merged 2 commits into from Nov 27, 2018
Merged

fix ncbi tbl parser for refseq accessions #899

merged 2 commits into from Nov 27, 2018

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Nov 27, 2018

The parser for tbl files was not parsing the underscore in accessions properly (which is present in most refseq accession numbers). Also added support for dbj entries. Added unit tests for parser.

Fixes annotation transfer scenarios from refseq tbl files such as NC_026438.1. Example kjsiddle failure here.

Copy link
Member

@tomkinsc tomkinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@dpark01 dpark01 merged commit 2165011 into master Nov 27, 2018
@dpark01 dpark01 deleted the dp-annot-fix branch November 27, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants