When determining available memory and cores, take into account cgroup limits #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkinsc
approved these changes
Dec 10, 2018
|
This is so much better, and thanks for deleting the hacky one-off scripts that kept reproducing themselves. BTW, it's much more correct to compute for container shape than host shape, and we should definitely merge this in. But out of curiosity, what's the use case you're addressing, kubernetes clusters? (most dnax and papi use cases have container shape = host shape) |
|
The use case is running large benchmarks on a single high-end instance with Cromwell's Local backend. E.g. running 200 rabies assemble_denovos this way costs under $8, vs. $238 on DNAnexus. |
notestaff
added a commit
that referenced
this pull request
Dec 10, 2018
is-better-handle-misassemblies : merged PR #905 (When determining available memory and cores, take into account cgroup limits)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining available memory and cores, take into account cgroup limits, which are used e.g. by docker run's --cpus and --memory options. Currently we use memory and cores values for the host machine, not the container.