Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

illumina.py: fixed small bug where exception was not raised for missing files #926

Merged
merged 4 commits into from
Feb 14, 2019
Merged

illumina.py: fixed small bug where exception was not raised for missing files #926

merged 4 commits into from
Feb 14, 2019

Conversation

notestaff
Copy link
Contributor

illumina.py: fixed small bug where exception was not raised for missing files

dpark01
dpark01 requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this bug!

It looks like we should use OSError instead?

dpark01
dpark01 approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@dpark01 dpark01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh even better -- we probably do want to read it anyway (not just know that it exists)

@notestaff notestaff merged commit aeb76dd into master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpark01 dpark01 dpark01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@notestaff @dpark01 @tomkinsc