This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
Optional evaluations and better errors. Closes broadinstitute/cromwell#1830 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjllanwarne
commented
Jan 17, 2017
| @@ -11,10 +11,10 @@ import scala.util.{Failure, Try} | |||
| trait WdlValue { | |||
| val wdlType: WdlType | |||
| def invalid(operation: String) = Failure(new WdlExpressionException(s"Cannot perform operation: $operation")) | |||
| def emptyValue(value: WdlOptionalValue) = Failure(VariableNotFoundException(value.toString)) | |||
| def evaluateIfDefined[A <: WdlValue](optionalValue: WdlOptionalValue, operation: WdlValue => Try[A]): Try[A] = optionalValue match { | |||
| def emptyValueFailure(operationName: String) = Failure(new UnsupportedOperationException(s"Sorry! Operation $operationName is not supported on empty optional values. You might resolve this using select_first(optional, default) to guarantee that you have a filled value.")) | |||
There was a problem hiding this comment.
Pinging @katevoss for critique!
cjllanwarne
commented
Jan 17, 2017
| @@ -11,10 +11,10 @@ import scala.util.{Failure, Try} | |||
| trait WdlValue { | |||
| val wdlType: WdlType | |||
| def invalid(operation: String) = Failure(new WdlExpressionException(s"Cannot perform operation: $operation")) | |||
| def emptyValue(value: WdlOptionalValue) = Failure(VariableNotFoundException(value.toString)) | |||
| def evaluateIfDefined[A <: WdlValue](optionalValue: WdlOptionalValue, operation: WdlValue => Try[A]): Try[A] = optionalValue match { | |||
| def emptyValueFailure(operationName: String) = Failure(new UnsupportedOperationException(s"Sorry! Operation $operationName is not supported on empty optional values. You might resolve this using select_first(optional, default) to guarantee that you have a filled value.")) | |||
There was a problem hiding this comment.
Maybe should be select_first([optional, default])
mcovarr
approved these changes
Jan 17, 2017
| @@ -11,10 +11,10 @@ import scala.util.{Failure, Try} | |||
| trait WdlValue { | |||
| val wdlType: WdlType | |||
| def invalid(operation: String) = Failure(new WdlExpressionException(s"Cannot perform operation: $operation")) | |||
| def emptyValue(value: WdlOptionalValue) = Failure(VariableNotFoundException(value.toString)) | |||
| def evaluateIfDefined[A <: WdlValue](optionalValue: WdlOptionalValue, operation: WdlValue => Try[A]): Try[A] = optionalValue match { | |||
| def emptyValueFailure(operationName: String) = Failure(new UnsupportedOperationException(s"Sorry! Operation $operationName is not supported on empty optional values. You might resolve this using select_first(optional, default) to guarantee that you have a filled value.")) | |||
|
👍 monads are like burritos, options are like doughnuts. |
|
@katevoss that |
|
👍 |
|
Will return later! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.