Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1622] No logs for you! #581

Merged
merged 10 commits into from
Feb 22, 2022
Merged

[GH-1622] No logs for you! #581

merged 10 commits into from
Feb 22, 2022

Conversation

tbl3rd
Copy link
Contributor

@tbl3rd tbl3rd commented Feb 19, 2022

Purpose

Changes

  • Fix bug in wfl.log/level-string?.
  • Add a wfl.unit.logging-test/endpoint test.
  • Expose the logging_level APIs in Swagger.
  • Update reitit.
  • Add some latent support for POST body data.
  • Expose the logging_level APIs in Swagger.
  • Remove some :refers and cleverness.

Review Instructions

  • Run the acceptance tests against a local server.
  • This PR will fail the wfl.unit.logging-test/endpoint test until WFL's deployed in dev.

@tbl3rd tbl3rd marked this pull request as ready for review February 19, 2022 00:49
@okotsopoulos okotsopoulos self-requested a review February 22, 2022 14:47
api/src/wfl/api/routes.clj Outdated Show resolved Hide resolved
api/test/wfl/unit/logging_test.clj Outdated Show resolved Hide resolved
Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Approving assuming system tests pass.

@tbl3rd tbl3rd merged commit ee4fcc7 into develop Feb 22, 2022
okotsopoulos pushed a commit that referenced this pull request Feb 22, 2022
* Update reitit.
* Reduce cleverness.
* Expose the logging_level API.
* Add logging_level endpoints.
* Fix bug in level-string? ... jeez.
* Add logging_level endpoint test.
* clojure -M:format` in this directory.
* Respond to OK's comments.
tbl3rd added a commit that referenced this pull request Feb 22, 2022
* [GH-1622] Fix WFL logging. (#581)
@tbl3rd tbl3rd deleted the tbl/GH-1622-no-logs branch February 25, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants