Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference resolution from values to declarations. #22

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

cjllanwarne
Copy link

Works on values that were part of a declaration. Doesn't currently work on task calls but that should be possible to add. Also doesn't reverse this via Find usages yet but again, this is a building block in the direction

Eg. using CMD+B on the morning value would bring us to the Boolean morning = true declaration.

workflow wf {
  Boolean morning = true
  String greeting = "good " + if morning then "morning" else "afternoon"
  call hello {
    input: s = greeting
  }
}

Copy link

@kshakir kshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjllanwarne cjllanwarne merged commit c9e3913 into develop Oct 17, 2017
@cjllanwarne cjllanwarne deleted the cjl_go_to_declaration branch October 17, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants