Make addFirewallRule return Operation

broadinstitute · Mar 21, 2020 · 3ac1b9a · 3ac1b9a
1 parent d96c86a
commit 3ac1b9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...2/src/main/scala/org/broadinstitute/dsde/workbench/google2/GoogleComputeInterpreter.scala b/...2/src/main/scala/org/broadinstitute/dsde/workbench/google2/GoogleComputeInterpreter.scala
@@ -119,11 +119,11 @@ private[google2] class GoogleComputeInterpreter[F[_]: Async: StructuredLogger: T
   }
 
   override def addFirewallRule(project: GoogleProject,
-                               firewall: Firewall)(implicit ev: ApplicativeAsk[F, TraceId]): F[Unit] =
+                               firewall: Firewall)(implicit ev: ApplicativeAsk[F, TraceId]): F[Operation] =
     retryF(
       Async[F].delay(firewallClient.insertFirewall(project.value, firewall)),
       s"com.google.cloud.compute.v1.FirewallClient.insertFirewall(${project.value}, ${firewall.getName})"
-    ).void
+    )
 
   override def getFirewallRule(project: GoogleProject, firewallRuleName: FirewallRuleName)(
     implicit ev: ApplicativeAsk[F, TraceId]

diff --git a/google2/src/main/scala/org/broadinstitute/dsde/workbench/google2/GoogleComputeService.scala b/google2/src/main/scala/org/broadinstitute/dsde/workbench/google2/GoogleComputeService.scala
@@ -46,7 +46,7 @@ trait GoogleComputeService[F[_]] {
                           instanceName: InstanceName,
                           metadata: Map[String, String])(implicit ev: ApplicativeAsk[F, TraceId]): F[Unit]
 
-  def addFirewallRule(project: GoogleProject, firewall: Firewall)(implicit ev: ApplicativeAsk[F, TraceId]): F[Unit]
+  def addFirewallRule(project: GoogleProject, firewall: Firewall)(implicit ev: ApplicativeAsk[F, TraceId]): F[Operation]
 
   def getFirewallRule(project: GoogleProject, firewallRuleName: FirewallRuleName)(
     implicit ev: ApplicativeAsk[F, TraceId]