Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-1433] Add google IAM retries #272

Merged
merged 2 commits into from Oct 8, 2019
Merged

[IA-1433] Add google IAM retries #272

merged 2 commits into from Oct 8, 2019

Conversation

rtitle
Copy link
Contributor

@rtitle rtitle commented Oct 8, 2019

Retry this case when modifying IAM roles:

com.google.api.client.googleapis.json.GoogleJsonResponseException: 429 Too Many Requests
{
  "code" : 429,
  "errors" : [ {
    "domain" : "global",
    "message" : "Quota exceeded for quota group 'WriteGroup' and limit 'CLIENT_PROJECT-100s' of service 'cloudresourcemanager.googleapis.com' for consumer 'project_number:635957978953'.",
    "reason" : "rateLimitExceeded"
  } ],
  "message" : "Quota exceeded for quota group 'WriteGroup' and limit 'CLIENT_PROJECT-100s' of service 'cloudresourcemanager.googleapis.com' for consumer 'project_number:635957978953'.",
  "status" : "RESOURCE_EXHAUSTED"
}

Previously we were retrying 429s but not with the global domain. Other methods in this class already use whenGlobalUsageLimited.

PR checklist

  • For each library you've modified here, decide whether it requires a major, minor, or no version bump. (Click here for guidance)

If you're doing a major or minor version bump to any libraries:

  • Bump the version in project/Settings.scala createVersion()
  • Update CHANGELOG.md for those libraries
  • I promise I used @deprecated instead of deleting code where possible

In all cases:

  • Replace the appropriate version hashes in README.md and the CHANGELOG.md for any libs you changed with TRAVIS-REPLACE-ME to auto-update the version string
  • Get two thumbsworth of PR review
  • Verify all tests go green (CI and coverage tests)
  • Squash commits and merge to develop
  • Delete branch after merge

@rtitle rtitle changed the title Add google IAM retries [IA-1433] Add google IAM retries Oct 8, 2019
@rtitle rtitle merged commit 58c913d into develop Oct 8, 2019
@Qi77Qi Qi77Qi deleted the rt-add-iam-retries branch October 9, 2019 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants