[no ticket] Add GoogleComputeService.modifyInstanceMetadata method #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
rtitle
changed the title
jdcanas
reviewed
Mar 31, 2020
| .setFingerprint(fingerprint) | ||
| .addAllItems((curItems.filterNot(i => metadata.contains(i.getKey)) ++ metadata.toList.map { | ||
| newItems = curItems | ||
| .filterNot(i => metadataToRemove.contains(i.getKey) || metadataToAdd.contains(i.getKey)) ++ metadataToAdd.toList |
There was a problem hiding this comment.
But I did! Some things even scalafmt can't clean up.
(I'll make this nicer :))
jdcanas
approved these changes
Mar 31, 2020
rtitle
force-pushed
the
rt-add-remote-metadata
branch
from
48b0a0f
to
41b551a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for Leo to remove metadata entries only needed for instance creation, not startup.
No breaking change or version bump.
See Leo PR: DataBiosphere/leonardo#1342
PR checklist
If you're doing a major or minor version bump to any libraries:
project/Settings.scalacreateVersion()CHANGELOG.mdfor those libraries@deprecatedinstead of deleting code where possibleIn all cases:
README.mdand theCHANGELOG.mdfor any libs you changed withTRAVIS-REPLACE-MEto auto-update the version string