Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-2341] Add nodepool operations to support Galaxy auto-stop #374

Merged
merged 4 commits into from
Nov 30, 2020

Conversation

rtitle
Copy link
Contributor

@rtitle rtitle commented Nov 18, 2020

https://broadworkbench.atlassian.net/browse/IA-2341

This will support a Leo change (not quite ready yet) to add stop/start operations to Galaxy/GKE.

Just adding methods, so no version bump necessary.

PR checklist

  • For each library you've modified here, decide whether it requires a major, minor, or no version bump. (Click here for guidance)

If you're doing a major or minor version bump to any libraries:

  • Bump the version in project/Settings.scala createVersion()
  • Update CHANGELOG.md for those libraries
  • I promise I used @deprecated instead of deleting code where possible

In all cases:

  • Replace the appropriate version hashes in README.md and the CHANGELOG.md for any libs you changed with TRAVIS-REPLACE-ME to auto-update the version string
  • Get two thumbsworth of PR review
  • Verify all tests go green (CI and coverage tests)
  • Squash commits and merge to develop
  • Delete branch after merge

Copy link
Contributor

@kyuksel kyuksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rtitle rtitle force-pushed the rt-gxy-autostop branch 2 times, most recently from d4cfd39 to 578137d Compare November 18, 2020 17:08

tracedGoogleRetryWithBlocker(
F.delay(clusterManagerClient.setNodePoolSize(request)),
f"com.google.cloud.container.v1.ClusterManagerClient.setNodePoolSize(${nodepoolId.toString}, ${nodeCount})"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why using f?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, typo

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@8d0c375). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #374   +/-   ##
==========================================
  Coverage           ?   22.63%           
==========================================
  Files              ?       76           
  Lines              ?     1776           
  Branches           ?       40           
==========================================
  Hits               ?      402           
  Misses             ?     1374           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0c375...816b9b4. Read the comment docs.

@rtitle rtitle merged commit 25fe292 into develop Nov 30, 2020
@rtitle rtitle deleted the rt-gxy-autostop branch November 30, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants