-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IA-2341] Add nodepool operations to support Galaxy auto-stop #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
d4cfd39
to
578137d
Compare
|
||
tracedGoogleRetryWithBlocker( | ||
F.delay(clusterManagerClient.setNodePoolSize(request)), | ||
f"com.google.cloud.container.v1.ClusterManagerClient.setNodePoolSize(${nodepoolId.toString}, ${nodeCount})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why using f
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, typo
578137d
to
08b63a9
Compare
49d32c9
to
5e75ade
Compare
5e75ade
to
816b9b4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #374 +/- ##
==========================================
Coverage ? 22.63%
==========================================
Files ? 76
Lines ? 1776
Branches ? 40
==========================================
Hits ? 402
Misses ? 1374
Partials ? 0 Continue to review full report at Codecov.
|
https://broadworkbench.atlassian.net/browse/IA-2341
This will support a Leo change (not quite ready yet) to add stop/start operations to Galaxy/GKE.
Just adding methods, so no version bump necessary.
PR checklist
If you're doing a major or minor version bump to any libraries:
project/Settings.scala
createVersion()
CHANGELOG.md
for those libraries@deprecated
instead of deleting code where possibleIn all cases:
README.md
and theCHANGELOG.md
for any libs you changed withTRAVIS-REPLACE-ME
to auto-update the version string