Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Plotting validation summary in 0.52 version #34

Closed
YubinXie opened this issue Feb 22, 2019 · 3 comments
Closed

Error in Plotting validation summary in 0.52 version #34

YubinXie opened this issue Feb 22, 2019 · 3 comments

Comments

@YubinXie
Copy link

YubinXie commented Feb 22, 2019

The 0.52 version fixed most of bugs in simulated data, but the last one (aka Plotting validation summary) still has a bug as attached.

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-9-14f90d916de1> in <module>()
     14 ot_model = wot.ot.initialize_ot_model(matrix_file, days_file,
     15                                       covariate=covariate_file, growth_iters=1, tmap_prefix='val')
---> 16 vs = wot.commands.compute_validation_summary(ot_model)
     17 vs['time'] = (vs['interval_start'] + vs['interval_end']) / 2
     18 vs['type'] = vs['pair0'].astype(str).str[0]

~/.local/lib/python3.6/site-packages/wot/commands/optimal_transport_validation.py in compute_validation_summary(ot_model, day_pairs_triplets, save_interpolated, interp_size, compute_full_distances)
     55 
     56     if has_covariate:
---> 57         ot_model.compute_all_transport_maps(with_covariates=True)
     58     if compute_full_distances:
     59         ot_model.compute_all_transport_maps()

~/.local/lib/python3.6/site-packages/wot/ot/ot_model.py in compute_all_transport_maps(self, with_covariates)
    218         else:
    219             for x in day_pairs:
--> 220                 self.compute_transport_map(*x)
    221 
    222     def compute_transport_map(self, t0, t1, covariate=None):

~/.local/lib/python3.6/site-packages/wot/ot/ot_model.py in compute_transport_map(self, t0, t1, covariate)
    264 
    265         config = {**self.ot_config, **local_config, 't0': t0, 't1': t1, 'covariate': covariate}
--> 266         tmap = OTModel.compute_single_transport_map(self.matrix, config)
    267         if tmap is not None:
    268             wot.io.write_dataset(tmap, output_file, output_format=self.output_file_format)

~/.local/lib/python3.6/site-packages/wot/ot/ot_model.py in compute_single_transport_map(ds, config)
    341         delta_days = t1 - t0
    342         config['g'] = config['g'] ** delta_days
--> 343         tmap = wot.ot.transport_stable_learn_growth(C, **config)
    344         return anndata.AnnData(tmap, p0.obs.copy(), p1.obs.copy())

TypeError: transport_stable_learn_growth() got an unexpected keyword argument 'tmap_prefix'

@joshua-gould
Copy link
Contributor

Thanks, I updated the documentation.

@geoffschieb
Copy link
Collaborator

geoffschieb commented May 11, 2019 via email

@YubinXie
Copy link
Author

That's great. Thank you for your notification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants