Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

answer this question please #131

Closed
cordoval opened this issue Jan 30, 2015 · 6 comments
Closed

answer this question please #131

cordoval opened this issue Jan 30, 2015 · 6 comments

Comments

@cordoval
Copy link
Contributor

could you please answer @mbadolato question here in the link but answer it in this github thread

https://gist.github.com/wjzijderveld/dcd9a6478346182b287a

thanks cc @wjzijderveld

@cordoval
Copy link
Contributor Author

i think i found the related explanation sort of here #109 (comment) onwards.

@mbadolato
Copy link
Contributor

No, those are two completely unrelated things. #109 was discussing the indexing and non-analyzed fields for Elasticsearch. The gist is asking about logic in a sample piece of code used to actually generate an index for one specific model (as opposed to all indexes)

@wjzijderveld
Copy link
Member

Commented:
We extend the ElasticsearchRepository for most of our repositories.
For repositories using the factory it won't work 😞

@mbadolato
Copy link
Contributor

Got it, thanks!

@cordoval
Copy link
Contributor Author

cordoval commented Feb 2, 2015

hmm how is the extended class of the ElasticsearchRepository of yours look like that it solves the issue @mbadolato referred to? just curious. 👶 and for completeness sake. I will close (he he) but if you happen to be of a good heart you can paste the gist. Thanks!

@wjzijderveld
Copy link
Member

The extended classes are usually just a constructor that define some of the
arguments for the base class.
And sometimes a method to do a specific query for that read model.
On 2 Feb 2015 03:55, "Luis Cordova" notifications@github.com wrote:

hmm how is the extended class of the ElasticsearchRepository of yours look
like that it solves the issue @mbadolato https://github.com/mbadolato
referred to? just curious. [image: 👶] and for completeness sake. I
will close but if you happen to be of a good heart you can paste the gist.
Thanks!


Reply to this email directly or view it on GitHub
#131 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants