Bugfixes in event-sourced-domain-with-tests #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ario->getEvents method: array_map only accepts an array and not an iterator. Using iterator_to_array() now.
renedekat
changed the title
othillo
reviewed
Dec 15, 2017
| @@ -34,7 +34,7 @@ public static function invite($invitationId, $name) | |||
| * | |||
| * {@inheritdoc} | |||
| */ | |||
| public function getAggregateRootId() | |||
| public function getAggregateRootId() : string | |||
There was a problem hiding this comment.
apparently the CS fixers fails. Can you remove the space before the colon? "public function getAggregateRootId(): string"
There was a problem hiding this comment.
Done, as well as added the examples folder to phpunit.xml.dist
| @@ -23,7 +23,7 @@ public function setUp() | |||
| $this->generator = new Broadway\UuidGenerator\Rfc4122\Version4Generator(); | |||
| } | |||
|
|
|||
| protected function getAggregateRootClass() | |||
| protected function getAggregateRootClass():string | |||
There was a problem hiding this comment.
protected function getAggregateRootClass(): string
sorry, the CS fixer is picky
added 3 commits
December 16, 2017 02:28
othillo
approved these changes
Dec 16, 2017
|
Thank you, @renedekat ! |
|
Now I just have to figure how to use it in a project :) I'm new to CQRS and Event Sourcing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed missing return types required in strict mode.
Fixed bug in Scenario->getEvents method: array_map only accepts an array and not an iterator. Using iterator_to_array() now.
Renamed InvitationTest class name to match filename.