Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in release 0.2.6 #35

Closed
krisselden opened this issue Aug 10, 2015 · 5 comments
Closed

Regression in release 0.2.6 #35

krisselden opened this issue Aug 10, 2015 · 5 comments

Comments

@krisselden
Copy link
Contributor

Broccoli funnel filters out files in subdirs that would have matched the include filters in earlier versions.

    var tree = new Funnel(iconsPath, {
      include: [ '*.scss' ],
    });
  readdirSync(iconsPath); // returns ['icons.scss', ...]
@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2015

A glob of *.scss generally should not include subdirectories (it should only match .scss files in the root of the tree), nested subdirectories would be matched by **/*.scss.

If it previously did match I guess it is a breaking change, but making *.scss match all subdir contents is somewhat weird.

@stefanpenner
Copy link
Contributor

the example and the description appear different. the example does not include sub-dirs for the matcher.

@rwjblue
Copy link
Member

rwjblue commented Aug 10, 2015

Can you give us an example contents of the input tree, and which specific files you expected to be matched by include: [ '*.scss' ]?

@stefanpenner
Copy link
Contributor

Anyways, I believe I have solved the issue. Or maybe just one that manifests in a similar way

stefanpenner added a commit to stefanpenner/node-walk-sync that referenced this issue Aug 10, 2015
ensure the cache key used for reusing MatcherCollections works when being provided matchers not string patterns
@stefanpenner
Copy link
Contributor

doing a NOM, should fix. Be sure your local copy of walk-sync-matcher is 0.2.2 or greater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants