Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add globbing support for include and exclude. #9

Merged
merged 1 commit into from
Dec 27, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 26, 2014

Closes #8.

@rwjblue
Copy link
Member Author

rwjblue commented Dec 26, 2014

/cc @stefanpenner

];

expect(walkSync(outputPath)).to.eql(expected);
it.skip('can take a function', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left it there intentionally as a placeholder for #10.

@stefanpenner
Copy link
Contributor

LGTM

return pattern.test(relativePath);
} else if (pattern.match) {
return pattern.match(relativePath);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should likely throw if neither of these branches are hit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to throw.

rwjblue added a commit that referenced this pull request Dec 27, 2014
Add globbing support for include and exclude.
@rwjblue rwjblue merged commit 8d792a2 into master Dec 27, 2014
@rwjblue rwjblue deleted the add-globbing-support branch December 27, 2014 01:29
@rwjblue
Copy link
Member Author

rwjblue commented Dec 27, 2014

Published in 0.1.7.

@marcenuc marcenuc mentioned this pull request May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thoughts on allowing string includes/excludes in addition to regexp?
2 participants