-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add globbing support for include and exclude. #9
Conversation
/cc @stefanpenner |
]; | ||
|
||
expect(walkSync(outputPath)).to.eql(expected); | ||
it.skip('can take a function', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left it there intentionally as a placeholder for #10.
LGTM |
return pattern.test(relativePath); | ||
} else if (pattern.match) { | ||
return pattern.match(relativePath); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should likely throw if neither of these branches are hit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to throw.
238eedb
to
948b257
Compare
Add globbing support for include and exclude.
Published in 0.1.7. |
Closes #8.