-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 10 doesn't support recursive directory operations. #197
Comments
Oiy. Good catch @chriseppstein. I think properly configuring |
@chriseppstein I noticed this when I added this functionality to
|
@SparshithNR Aha! That explains why there wasn't an error. So the issue then is just with the types in |
… node version support. Closes broccolijs#197.
So the 3.0 release has a bug in node 10 that evidently isn't covered by the test cases.
This project is using
@types/node
@^13
which didn't flag this as an issue. (I recommend we downgrade to^10
).According to the node.js docs, recursive rmdir was added in 12.10.0.
The API is used here: https://github.com/broccolijs/broccoli-persistent-filter/blob/master/index.ts#L228-L229
Maybe the right fix is for the fs-merger to shim the node-12 api when in node 10?
cc: @SparshithNR @stefanpenner
The text was updated successfully, but these errors were encountered: