-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure with dev testthat #266
Comments
I'll have some time next week to look at this, but in the meantime, I can imagine this type of thing will happen if code outside of Last time this came about we had one of those fun conversations. I recommend you don't read through that whole thing again, but just throwing it out there in case it rings a bell with any changes that may be fresh in your mind relating to wrapping out of I could also be completely wrong about my guess. I'll confirm next week. |
That makes me wonder if r-lib/testthat#1004 is related, but looking at the code I don't think it changed how the code is executed, just how errors are reported. |
So the issue that I linked last time was that Now it's been both deprecated and removed (well, strictly speaking it hasn't been removed, but it's removed from |
The problem is that it adds complexity to a part of testthat is almost as complex as my brain can handle, and as far as I can tell, you're the only person that uses it. |
I understand, and it's unfortunate that the behavior changed from when I started to use testthat for this project. Unfortunately "fixing" this in my code is not completely trivial (and might even require C code, or adding a dependency to rlang, neither of which I'm really that interested in) as it involves a very complex part of the Would you consider just deprecating this for at least one release cycle instead of immediately removing it? In my mind "deprecation" involves some kind of managed glide path were folks are given a few release cycles to wean off functionality that is considered no longer maintenance-worthy. |
I'd consider it if you did a PR, but as I said, it's a complex part of testthat that I don't really want to mess with. I agree that deprecation would be desirable here, but this is just a place where I have to make a judgement call based on the amount of existing code in the wild that uses it. |
Ok, I'll submit a PR. From looking at the code I think it will be much simpler to restore this functionality at least temporarily than try to resolve the |
Fixed by r-lib/testthat#1183 |
Again, not sure what's going on here, but please let me know if there's anything I can do to help.
I'm planning to submit testthat to CRAN in about a month.
The text was updated successfully, but these errors were encountered: