refactor!: rename some options #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
brodybits
force-pushed
the
rename-some-options
branch
from
75ff2e9
to
48da20f
Compare
brodybits
added a commit
that referenced
this pull request
Mar 16, 2021
|
@brodybits FYI this change broke our CI since we use create-react-native-module --module-name and the new npm package version doesn't have that option; it sounds like this should have required a major version update. #441 |
BartoszKlonowski
added a commit
to callstack-internal/react-native-windows-samples
that referenced
this pull request
May 21, 2021
The code presented in the docs for creating the NativeModuleSample still had the --module-name option, which was renamed to --package-name in: brodybits/create-react-native-module#431 This commit removes this option, as the --package-name is optional and by default the name will be set as the one used as second parameter.
NickGerleman
pushed a commit
to microsoft/react-native-windows-samples
that referenced
this pull request
May 24, 2021
…odule` (#440) * Remove --module-name option from module creation code The code presented in the docs for creating the NativeModuleSample still had the --module-name option, which was renamed to --package-name in: brodybits/create-react-native-module#431 This commit removes this option, as the --package-name is optional and by default the name will be set as the one used as second parameter. * Separate `create-react-native-module` as another option Official React Native instructions use react-native-builder-bob from Callstack.io company to create the native module project, while the example presented below it uses other community library. It is essential to emphasize that these are not the same ways to create the project. This commit adds "or" to ensure that the reader will be aware of those options.
matsudaWWW
added a commit
to matsudaWWW/reactNative-sample
that referenced
this pull request
Dec 17, 2023
…odule` (#440) * Remove --module-name option from module creation code The code presented in the docs for creating the NativeModuleSample still had the --module-name option, which was renamed to --package-name in: brodybits/create-react-native-module#431 This commit removes this option, as the --package-name is optional and by default the name will be set as the one used as second parameter. * Separate `create-react-native-module` as another option Official React Native instructions use react-native-builder-bob from Callstack.io company to create the native module project, while the example presented below it uses other community library. It is essential to emphasize that these are not the same ways to create the project. This commit adds "or" to ensure that the reader will be aware of those options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(part of release
0.2.0as discussed in #409)--module-nameoption to--package-name--package-identifieroption to '--native-package-id`--example-react-native-versionto--example-react-native-templateBREAKING CHANGE: affects anyone using the renamed options