Fix: --module-name is no longer supported in create-react-native-module
#440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code presented in the docs for creating the NativeModuleSample still had the --module-name option, which was renamed to --package-name in: brodybits/create-react-native-module#431 This commit removes this option, as the --package-name is optional and by default the name will be set as the one used as second parameter.
Official React Native instructions use react-native-builder-bob from Callstack.io company to create the native module project, while the example presented below it uses other community library. It is essential to emphasize that these are not the same ways to create the project. This commit adds "or" to ensure that the reader will be aware of those options.
NickGerleman
approved these changes
May 21, 2021
asklar
approved these changes
May 21, 2021
|
thanks @BartoszKlonowski ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
--module-nameoption from the example of creating the native module library project using the create-react-native-module library.The
--module-nameoption has been renamed to--package-namein PR#431, moreover it is optional to use, as it defaults to the name given in the parameter.Another change introduced in this pull request is the separation of following official React Native instructions from following the bat code steps presented below it.
React Native instructions use callstack/react-native-builder-bob while examples presented in these docs use brodybits/create-react-native-module.
It is important to emphasize that these two libraries are different and may (and soon will) lead to different results.
IMPORTANT NOTE: Within next week (24.05 - 28.05) the callstack/react-native-builder-bob will be provided with Windows support, which will make the further steps presented in this document unnecessary (but still necessary if brodybits/create-react-native-module is used instead).
Once this happens, the guide will have to be further modified, but the scope of this PR is to ensure the difference is known to user/developer and no
--module-nameoption is there to increase confusion.Microsoft Reviewers: Open in CodeFlow