Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): introduce prettier-config-x-standard #98

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

brodycj
Copy link
Owner

@brodycj brodycj commented Feb 16, 2021

No description provided.

@brodycj brodycj added the bug Something isn't working label Feb 16, 2021
@brodycj
Copy link
Owner Author

brodycj commented Feb 16, 2021

With prettier-config-x-standard, npx prettier --write main.js makes the following changes, which do not look right:

diff --git a/main.js b/main.js
index 78a623e..f17dab5 100644
--- a/main.js
+++ b/main.js
@@ -196,22 +196,22 @@ Promise.resolve().then(async () => {
   const { androidPackageId } =
     platforms.indexOf('android') !== -1
       ? await prompt({
-          type: 'text',
-          name: 'androidPackageId',
-          message: 'What is the desired Android package id?',
-          initial: 'com.demo',
-          validate: androidPackageId => androidPackageId.length > 0
-        })
+        type: 'text',
+        name: 'androidPackageId',
+        message: 'What is the desired Android package id?',
+        initial: 'com.demo',
+        validate: androidPackageId => androidPackageId.length > 0
+      })
       : { androidPackageId: null }
 
   const { tvosEnabled } =
     platforms.indexOf('ios') !== -1
       ? await prompt({
-          type: 'confirm',
-          name: 'tvosEnabled',
-          message: 'Support Apple tvOS (requires react-native-tvos fork)?',
-          initial: false
-        })
+        type: 'confirm',
+        name: 'tvosEnabled',
+        message: 'Support Apple tvOS (requires react-native-tvos fork)?',
+        initial: false
+      })
       : { tvosEnabled: null }
 
   // THANKS to @react-native-community/bob for the idea
@@ -250,11 +250,11 @@ Promise.resolve().then(async () => {
   const { useAppleNetworking } =
     platforms.indexOf('ios') !== -1 && !isView
       ? await prompt({
-          type: 'confirm',
-          name: 'useAppleNetworking',
-          message: 'Generate with sample use of Apple Networking?',
-          initial: false
-        })
+        type: 'confirm',
+        name: 'useAppleNetworking',
+        message: 'Generate with sample use of Apple Networking?',
+        initial: false
+      })
       : { useAppleNetworking: false }
 
   log(INFO, 'It is possible to generate an example app for testing,')
@@ -270,28 +270,28 @@ Promise.resolve().then(async () => {
 
   const exampleAppName = generateExampleApp
     ? (
-        await prompt({
-          type: 'text',
-          name: 'exampleAppName',
-          message: 'Example app name?',
-          initial: 'example'
-        })
-      ).exampleAppName
+      await prompt({
+        type: 'text',
+        name: 'exampleAppName',
+        message: 'Example app name?',
+        initial: 'example'
+      })
+    ).exampleAppName
     : null
 
   const exampleTemplate = generateExampleApp
     ? (
-        await prompt({
-          type: 'text',
-          name: 'exampleTemplate',
-          message: `What react-native template to use for the example app (should be for at least ${
-            tvosEnabled ? 'react-native-tvos@0.60' : 'react-native@0.60'
-          })?`,
-          initial: tvosEnabled
-            ? 'react-native-tvos@latest'
-            : 'react-native@latest'
-        })
-      ).exampleTemplate
+      await prompt({
+        type: 'text',
+        name: 'exampleTemplate',
+        message: `What react-native template to use for the example app (should be for at least ${
+          tvosEnabled ? 'react-native-tvos@0.60' : 'react-native@0.60'
+        })?`,
+        initial: tvosEnabled
+          ? 'react-native-tvos@latest'
+          : 'react-native@latest'
+      })
+    ).exampleTemplate
     : null
 
   if (generateExampleApp) {

Enabling the offsetTernaryExpressions: true on Prettier in eslintrc.yml seems to have the same effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant