This repository has been archived by the owner on Feb 8, 2020. It is now read-only.
feat(utils): log fileInfo errors at parent log level, demote warning #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of keeping a stand alone logger instance in the fileInfo utility method pass in the (optional) logger from the parent, enabling the user to use the same log level for all messages
dustinblackman
approved these changes
Apr 30, 2017
killix
approved these changes
May 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, every message that will be parsed by any integration will always pass the
fileInfoutility method. This method will log a message on every missing file (which is basically on almost every message) at error level, and there is currently no way of having this respect a any other user set log level. This is very noisy and also rather confusing in production as it logs something like this on every incoming message:Instead, this PR demotes the message to debug level and uses the logger of the parent integration for logging this, so that we respect the log level set on the parent.