Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted grey line when toolbar is at bottom #1995

Closed
4 tasks done
ghost opened this issue Apr 19, 2022 · 6 comments
Closed
4 tasks done

Unwanted grey line when toolbar is at bottom #1995

ghost opened this issue Apr 19, 2022 · 6 comments

Comments

@ghost
Copy link

ghost commented Apr 19, 2022

Preliminary checklist

  • I have read the README.
  • I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
  • I have read the FAQs.
  • I have updated Bromite to the latest version. The bug is reproducible on this latest version.

Can the bug be reproduced with corresponding Chromium version?

No

Bromite version

100.0.4896.135

Device architecture

arm64-v8a

Android version

10

Device model

Huawei Nova CDY-NX9B

Changed flags

Screenshot_20220419_123637

Is this bug about the SystemWebView?

No

Is this bug happening in an incognito tab?

No

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

A thin grey line appears where the bottom of the toolbar used to be before "move top toolbar to bottom" flag is set.

Line is present in tab grid and in websites when scrolling up, at the same time when toolbar appears after being hidden.

Steps to reproduce the bug

Tab Grid:

  1. Go to tab grid.
  2. Line appears.

Website:

  1. Go to https://www.iana.org/domains/reserved.
  2. Scroll down until toolbar is hidden.
  3. Scroll up untill toolbar appears.
  4. Line appears.

Expected behavior

Line should not be present when toolbar is at the bottom.

Screenshots

Screenshot_20220419_121340_org bromite bromite_1

@kokukyocho
Copy link
Collaborator

Hello @IconBunnyGoing!

I am a bot 🤖

Thanks for submitting this issue!
I noticed that it is missing the template, please edit the issue to match the template for either a bug or a feature request; the issue will be automatically re-opened afterwards.

If this is not an issue nor a feature request and you want to start a discussion then you can use GitHub Discussions.

Tip: if you use GitHub in Desktop mode the template will be proposed to you when submitting issues.

@kokukyocho kokukyocho added missing-issue-template This issue was not created with the issue template bug needs-triage and removed missing-issue-template This issue was not created with the issue template labels Apr 19, 2022
@kokukyocho kokukyocho reopened this Apr 19, 2022
@uazo
Copy link
Collaborator

uazo commented Apr 19, 2022

I confirm, I'll take care of it.

@pritkr
Copy link

pritkr commented Apr 19, 2022

Also gestures are hard from bottom toolbar
You need to swipe downwards in the toolbar to open the tab switcher
Can it be madeso that swiping upwards in toolbar opens tab switcher?

@ghost
Copy link
Author

ghost commented Apr 20, 2022

Also gestures are hard from bottom toolbar You need to swipe downwards in the toolbar to open the tab switcher Can it be madeso that swiping upwards in toolbar opens tab switcher?

I think a new issue needs to be opened for that, or can this issue be changed to include all issues regarding moving the toolbar to the bottom?

@uazo
Copy link
Collaborator

uazo commented Apr 20, 2022

You need to swipe downwards in the toolbar to open the tab switcher

yes, that's right, I deliberately left it that way.
the idea is in the future to use the swipe upwards to open a summary panel related to privacy and blocked network requests, taking advantage of the opening of the devtools as kiwi does.

@csagan5
Copy link
Contributor

csagan5 commented May 2, 2022

Fixed in 101.0.4951.53.

@csagan5 csagan5 closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants