Fix Move-navigation-bar-to-bottom.patch #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume no side effects for non-A7 owners? |
no effect, it is under version checking. |
In this case I will change the comment to mention Android Nougat. |
ChanningPromethean
pushed a commit
to PrometheanWorld/bromite
that referenced
this pull request
May 12, 2023
* fix 1995 and 2011 * fixgit apply Co-authored-by: Carmelo Messina <uazo@users.noreply.github.com>
ChanningPromethean
pushed a commit
to PrometheanWorld/bromite
that referenced
this pull request
May 12, 2023
Merge in AP/chromiumpatches from upstream-101.0.4951.69 to master * commit 'e27c948d5ef6b3ff8f36a70b313a7d74d043adb0': (88 commits) AP9-5174 Update Chromium code to latest Release 101.0.4951.69 Update build/patches/Add-webrtc-site-setting.patch Add webRTC site settings Do not specify 'latest' fix odd behaviour with search or site suggestions Add Android 12L to version list Add a flag to site engagement feature Add webgl site setting Add missing CHANGELOG entries Release 101.0.4951.53 Fix merge typo in privacy patch Updated patches for v101 multiple fixes reverse the order of appmenu Fix Move-navigation-bar-to-bottom.patch (bromite#2029) Release 101.0.4951.39 Patches for v101 (bromite#2010) Quote grep expression Document home page as NTP ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bug of #2011 is present in all versions because the offset of the menu is not correctly calculated and is off-screen, but only in A7 is it taken into account.
in the other android versions it automatically adjusts the offsets to make the menu be always visible.
in addition, and only in A7, the menu is not drawn correctly if the bar is docked at the bottom, for this reason I reduce the size so that it is pleasant but still functional.
Fix for #1995
Fix for #2011