Disable conversion measurement api #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csagan5
reviewed
Nov 15, 2021
| { | ||
| name: "ConversionMeasurementEventSources", | ||
| - status: "test", | ||
| + depends_on: ["DisabledForBromite"], |
There was a problem hiding this comment.
If you start using this, shouldn't the other patches also use this approach?
There was a problem hiding this comment.
in fact, I put the statement in the other patch (#1582)...
if you don't merge that it won't compile.
maybe it is the case to put it alone.
beware that once again I have not added it to the patch list
csagan5
approved these changes
Nov 15, 2021
ChanningPromethean
pushed a commit
to PrometheanWorld/bromite
that referenced
this pull request
May 12, 2023
Co-authored-by: Carmelo Messina <uazo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
Conversion Measurement APIby disabling the flag and removing support for the AttributionReporting provider. it also removes the handling of attributions via intents between apps.This patch enforces the deactivation by preventing the report from being sent and being saved to disk, although it is currently in uncalled code.
For this patch I preferred the "soft" approach for two reasons. The first is that the deletion is intrusive (this is the patch that completely removes it), the second is that I have seen that it is still under development and in any case the flag actually seems to disable most of the code.
what was left I took off.
consider that it is currently active in bromite.
fix #1531