Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.types in conflict with mime.types #51

Closed
broofa opened this issue Jan 10, 2013 · 5 comments
Closed

node.types in conflict with mime.types #51

broofa opened this issue Jan 10, 2013 · 5 comments

Comments

@broofa
Copy link
Owner

broofa commented Jan 10, 2013

$ DEBUG=1 node -e "require('./mime')"

shows several extensions where node.types redefines a type defined in mime.types. Specifically:

node.types changes "rtf" extension type from application/rtf to text/rtf
node.types changes "bmp" extension type from image/bmp to image/x-ms-bmp
node.types changes "otf" extension type from application/x-font-otf to font/opentype
node.types changes "m3u8" extension type from application/vnd.apple.mpegurl to application/x-mpegURL
node.types changes "flac" extension type from audio/x-flac to audio/flac

Are there any objections to removing the definitions above from node.types? (Speak now or hold your peace!) Removing the node type has two impacts:

  1. mime.lookup(_extension_) will return the type defined by mime.types rather than node.types. E.g. mime.lookup('rtf') would beapplication/rtf`
  2. mime.extension(_node_type_) will return undefined. E.g. mime.extension('text/rtf') would be undefined
@broofa
Copy link
Owner Author

broofa commented Jan 10, 2013

@francois2metz
Copy link
Contributor

Ok for me.

@mab-work
Copy link

Works for me.

@creationix
Copy link

No argument here.

broofa added a commit that referenced this issue Jan 11, 2013
@dubiousdavid
Copy link

Can this be closed?

@broofa broofa closed this as completed Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants