Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve insert method used #381

Merged
merged 18 commits into from
Sep 18, 2023
Merged

Improve insert method used #381

merged 18 commits into from
Sep 18, 2023

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented Sep 13, 2023 •
edited

Overview

As noted in #305 there has been a long-standing need to add the column names into the insert statements for each table to make upgrading easier and more robust. This adds those column names along with some improvements to the macros folder:

  • Addition of sub-folders to make identifying macros easier
  • Addition of macro documentation
  • Tidy up of upload_results script to make it more DRY

Additionally picked up this very related issue:

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@glsdown glsdown added the quality of life A general improvement, that isn't a new feature or a bug label Sep 13, 2023
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:33 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:33 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:33 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:37 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:37 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:37 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:37 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:38 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:38 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:38 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:38 — with GitHub Actions Inactive
This was linked to issues Sep 13, 2023
Remove unused rows_affected column from test_executions #195
Open
[Feature]: Provide list of columns to insert macro #305
Closed
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:54 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:54 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:54 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 13, 2023 15:58 — with GitHub Actions Inactive
@glsdown glsdown mentioned this pull request Sep 14, 2023
Open
@ghost
Copy link

ghost commented Sep 16, 2023

Much appreciated

@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:03 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:03 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:03 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:06 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:06 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:06 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:07 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:07 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:07 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:07 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:07 — with GitHub Actions Inactive
jared-rimmer
jared-rimmer reviewed Sep 18, 2023
View reviewed changes
macros/upload_results/get_column_name_lists.sql Outdated Show resolved Hide resolved
macros/upload_results/get_column_name_lists.sql Outdated Show resolved Hide resolved
macros/upload_results/get_column_name_lists.sql Outdated Show resolved Hide resolved
macros/upload_results/get_column_name_lists.sql Outdated Show resolved Hide resolved
macros/upload_results/get_column_name_lists.sql Outdated Show resolved Hide resolved
macros/upload_results/get_column_name_lists.sql Outdated Show resolved Hide resolved
macros/upload_results/get_column_name_lists.sql Outdated Show resolved Hide resolved
macros/database_specific_helpers/get_relation.sql Outdated Show resolved Hide resolved
macros/database_specific_helpers/get_relation.sql Outdated Show resolved Hide resolved
macros/database_specific_helpers/get_relation.sql Show resolved Hide resolved
@glsdown @jared-rimmer
Apply suggestions from code review
18e371a 
Co-authored-by: Jared Rimmer <100997264+jared-rimmer@users.noreply.github.com>
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:18 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:18 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:18 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:28 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:28 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:28 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:28 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:28 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:28 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:28 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 18, 2023 13:28 — with GitHub Actions Inactive
@glsdown glsdown merged commit 7a33172 into main Sep 18, 2023
11 checks passed
@glsdown glsdown deleted the feat/improve-insert-methods branch September 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jared-rimmer jared-rimmer jared-rimmer approved these changes

Assignees
No one assigned
Labels
quality of life A general improvement, that isn't a new feature or a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Does not work with Snowflake and quoting true [Feature]: Provide list of columns to insert macro
2 participants
@glsdown @jared-rimmer