Webhooks notifications based on ENV vars

[tareksamni]

Webhooks notifications based on ENV vars with unit tests covered.

Missing: Code documentation for new modules and classes

[brotandgames]

Looks great 👍

Going to test the new feature in our staging environment with RocketChat.
If you are interested - this is done by: git push dokku tareksamni-master:master since we are currently using dokku for building and testing ciao.

Should we expand the placeholder possibilites with check_url and url?

[tareksamni]

Yes, I can do that. Should we add:

1. check_url is the url that we ping to checkhealth.
2. ciao_url is the "#show" link to the specific check that changed.

I was also thinking to move the CheckMailer call to a Notification of type MailNotification that implements #notify and use polymorphism. Then append an instance of it to NOTIFICATIONS in the initialiser. To be more consistent.

[brotandgames]

I would stay consistent here (with AR and the JSON API) and remove check_from check_name and

• url is the url that we ping to checkhealth.
• check_url is the "#show" link to the specific check that changed.

I was also thinking to move the CheckMailer call to a Notification of type MailNotification that implements #notify and use polymorphism. Then append an instance of it to NOTIFICATIONS in the initialiser. To be more consistent.

Sounds good 👍

Would only add that the Mailer should be added only if ENV['SMTP_ADDRESS'] is defined - suppose you were thinking of it.

[brotandgames]

Tested with private RocketChat instance: works 👍

Will update example configuration for RocketChat in md.