Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for is_active #50

Closed
helenst opened this issue Apr 26, 2017 · 2 comments
Closed

Check for is_active #50

helenst opened this issue Apr 26, 2017 · 2 comments

Comments

@helenst
Copy link
Contributor

helenst commented Apr 26, 2017

Django's RemoteUserBackend (as of 1.11) does not allow login from users with is_active=False This seems like a good thing to have in ShibbolethRemoteUserBackend too. Would you accept a PR for this?
@bcail
Copy link
Contributor

bcail commented Apr 26, 2017

Sure, thanks. Open one and I'll take a look at it. Tests in the PR would be great.

@helenst helenst mentioned this issue Apr 26, 2017
Merged
@helenst
Copy link
Contributor Author

helenst commented May 24, 2017

I fixed this, so closing it :)

@helenst helenst closed this as completed May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helenst @bcail