Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the weak argument from Signal.disconnect() #208

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

browniebroke
Copy link
Owner

Fixes #120

@browniebroke browniebroke added the enhancement New feature or request label Sep 20, 2020
@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        24    +1     
  Lines          698       740   +42     
=========================================
+ Hits           698       740   +42     
Impacted Files Coverage Δ
django_codemod/visitors/__init__.py 100.00% <100.00%> (ø)
django_codemod/visitors/signals.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4bb4c...ab41491. Read the comment docs.

@browniebroke browniebroke force-pushed the feat/signal-disconnect-weak-kwargs branch from 457021c to c81de59 Compare September 21, 2020 08:36
@browniebroke browniebroke force-pushed the feat/signal-disconnect-weak-kwargs branch from c81de59 to ab41491 Compare September 21, 2020 08:55
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 21, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 0.05 ⭐ 0.05 ⭐ 0.00
Method Length 39.30 ⭐ 39.55 ⭐ 0.25 👎
Working memory 9.95 😞 10.10 😞 0.15 👎
Quality 84.37% 84.32% -0.05% 👎
Other metrics Before After Change
Lines 329 333 4
Changed files Quality Before Quality After Quality Change
django_codemod/visitors/init.py 56.20% 🙂 55.65% 🙂 -0.55% 👎
tests/test_cli.py 85.85% ⭐ 85.83% ⭐ -0.02% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/test_cli.py test_deprecated_in_mapping 0 69 🙂 40 ⛔ 57.29% 🙂 Extract out complex expressions
tests/test_cli.py test_removed_in_mapping 0 61 ⭐ 38 ⛔ 58.59% 🙂 Extract out complex expressions
tests/test_cli.py test_basic_arguments 1 ⭐ 94 🙂 11 😞 66.94% 🙂 Extract out complex expressions
tests/test_cli.py test_get_short_description 0 32 ⭐ 11 😞 77.52% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@browniebroke browniebroke merged commit a2259f3 into master Sep 21, 2020
@browniebroke browniebroke deleted the feat/signal-disconnect-weak-kwargs branch September 21, 2020 10:07
@browniebroke browniebroke added this to the Django 2.0 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed weak argument to django.dispatch.signals.Signal.disconnect()
1 participant