feat(ci): enable cache in setup-python #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't found this to make a massive difference in my cases, and the workflow is more complicated (more lines) so not really worth it. |
|
This is useful in the rare case of installing a library that takes an inordinate amount of time to install or using many libraries. However I'm also not sure if it should be in the template. (How about commenting it out or making this optional then?) I would appreciate it if you could take a look at other PRs as well, thank you |
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - uses: snok/install-poetry@v1.3.4 |
There was a problem hiding this comment.
I've just realised that this action uses the deprecated install script, and that the solution you suggest is the recommended one 👍
browniebroke
approved these changes
May 22, 2024
|
Thanks for the effort and your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#caching-packages
This may speed up the test slightly. (although it will take longer to install poetry anyway)