Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): enable cache in setup-python #682

Merged
merged 4 commits into from
May 22, 2024
Merged

feat(ci): enable cache in setup-python #682

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca89cc9
feat(ci): enable cache in setup-python
34j Mar 4, 2024
c6abf52
fix: update ci.yml
34j Mar 4, 2024
ea4150a
Remove comment
browniebroke May 22, 2024
e2788f5
Merge branch 'main' into feat/cache-packages
browniebroke May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion project/.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,16 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Install poetry
run: pipx install poetry
# https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#caching-packages
browniebroke marked this conversation as resolved.
Show resolved Hide resolved
- name: Set up Python
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ matrix.python-version }}
- uses: snok/install-poetry@v1.3.4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just realised that this action uses the deprecated install script, and that the solution you suggest is the recommended one 👍

cache: "poetry"
- run: echo "Cache hit:${{ steps.setup-python.outputs.cache-hit }}" # true if cache-hit occurred on the primary key
- name: Install Dependencies
run: poetry install
shell: bash
Expand Down