Improving QQBrowser detection, separating platforms some to reduce pattern count #1496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1495.
Adding platforms/versions/patterns for QQ Browser to improve detection and eliminate some mis-detections I was seeing.
As mentioned in the issue, I did split the files up since the version ranges seem to differ from platform to platform. For the low end of the versions, I tried to only inlucde what I’ve seen with UAs.
I was able to reduce the pattern count some by doing this, here’s line count and pattern count for
master
today:And here’s this branch (based from
master
):Also, here’s a browser name comparison between master and this branch for about 1,600 UAs I collected that should be QQBrowser: