Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Chedot version/pattern #1570

Merged
merged 1 commit into from
Sep 5, 2017
Merged

New Chedot version/pattern #1570

merged 1 commit into from
Sep 5, 2017

Conversation

jaydiablo
Copy link
Contributor

Fixes #1569.

Added a new pattern for Chedot 8.0 which varies slightly from the existing patterns.

Added a 3.4 file as well, to catch some UAs we’ve seen. I didn’t think it was good to add 3.4 to the file that has version 43 in it, as we’ve never seen the Chrome/3.4 style pattern for this version of Chedot.

Also renamed the 28-on file since it only contains one version (43.0), which is also the only version in that style of UA that we’ve seen.

Added tests from UAs in our logs to cover any uncovered patterns.

@@ -47,7 +49,9 @@
"Win10_x64", "Win10_64", "Win10_32",
"Win8_1_x64", "Win8_1_64", "Win8_1_32",
"Win8_x64", "Win8_64", "Win8_32",
"Win7_x64", "Win7_64", "Win7_32"
"Win7_x64", "Win7_64", "Win7_32",
"Vista_64", "Vista_32",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and I did add Win Vista and XP to these patterns because their site mentions that the browser is available for these platforms: http://landing.chedot.com

@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #1570 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1570      +/-   ##
============================================
- Coverage     41.68%   41.68%   -0.01%     
  Complexity      763      763              
============================================
  Files          1534     1536       +2     
  Lines         52984    53025      +41     
  Branches      21068    21100      +32     
============================================
+ Hits          22086    22101      +15     
- Misses        30898    30924      +26
Impacted Files Coverage Δ Complexity Δ
...es/user-agents/browsers/chedot/chedot-generic.json 0% <0%> (ø) 0 <0> (ø) ⬇️
...urces/user-agents/browsers/chedot/chedot-43-0.json 65% <33.33%> (ø) 0 <0> (?)
...ources/user-agents/browsers/chedot/chedot-8-0.json 60% <60%> (ø) 0 <0> (?)
...ources/user-agents/browsers/chedot/chedot-3-4.json 70% <70%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a036276...e129b9a. Read the comment docs.

@mimmi20 mimmi20 self-assigned this Sep 5, 2017
@mimmi20 mimmi20 added this to the 6025 milestone Sep 5, 2017
@mimmi20 mimmi20 merged commit 7545431 into browscap:master Sep 5, 2017
@jaydiablo jaydiablo deleted the issue-1569 branch September 5, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants