Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update coding style #1583

Merged
merged 1 commit into from
Sep 20, 2017
Merged

update coding style #1583

merged 1 commit into from
Sep 20, 2017

Conversation

mimmi20
Copy link
Member

@mimmi20 mimmi20 commented Sep 20, 2017

This PR updates the coding style and switches from codesniffer to cs-fixer for the tests. Additional to this I changed my Email-Adress and removed some duplicate or unused constants. I also removed the unused IniParser classes.

This PR is required for PR #1579.

@mimmi20 mimmi20 added this to the 6025 milestone Sep 20, 2017
@mimmi20 mimmi20 mentioned this pull request Sep 20, 2017
@codecov
Copy link

codecov bot commented Sep 20, 2017

Codecov Report

Merging #1583 into master will decrease coverage by 0.06%.
The diff coverage is 93.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1583      +/-   ##
============================================
- Coverage     43.84%   43.78%   -0.07%     
+ Complexity      777      751      -26     
============================================
  Files          1543     1542       -1     
  Lines         53301    53240      -61     
  Branches      21245    21245              
============================================
- Hits          23372    23310      -62     
- Misses        29929    29930       +1
Flag Coverage Δ Complexity Δ
#full 39.79% <ø> (ø) 0 <ø> (ø) ⬇️
#lite 1.53% <ø> (ø) 0 <ø> (ø) ⬇️
#standard 21.65% <ø> (ø) 0 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Browscap/Filter/StandardFilter.php 94.11% <ø> (ø) 10 <0> (ø) ⬇️
src/Browscap/Helper/LoggerHelper.php 100% <ø> (ø) 1 <0> (ø) ⬇️
.../Browscap/Writer/Factory/FullCollectionFactory.php 100% <ø> (ø) 1 <0> (ø) ⬇️
src/Browscap/Data/Division.php 100% <ø> (ø) 8 <0> (ø) ⬇️
src/Browscap/Data/Factory/EngineFactory.php 66.66% <ø> (ø) 7 <0> (ø) ⬇️
src/Browscap/Data/Engine.php 100% <ø> (ø) 2 <0> (ø) ⬇️
...c/Browscap/Writer/Factory/FullPhpWriterFactory.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Browscap/Filter/FullFilter.php 92.3% <ø> (ø) 6 <0> (ø) ⬇️
src/Browscap/Data/Factory/PlatformFactory.php 31.42% <ø> (ø) 11 <0> (ø) ⬇️
src/Browscap/Filter/LiteFilter.php 93.33% <ø> (ø) 9 <0> (ø) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d8257...72914e0. Read the comment docs.

@jaydiablo jaydiablo merged commit 41d0a24 into browscap:master Sep 20, 2017
@mimmi20 mimmi20 deleted the change-coding-style branch September 20, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants