Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Nintendo Browser and Nintendo platforms #1599

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

jaydiablo
Copy link
Contributor

Fixes #1589

I moved the patterns for Nintendo devices to a single “Nintendo Browser” and made some versions from that. Also added platforms for all of the Nintendo devices (basically just match the platform). From what I can tell, Nintendo doesn’t really have any fancy names for their OSes like Sony does.

I collected all Nintendo related UAs I could find and ran them through these changes and made tests from any that added coverage.

The older browsers (like on the DS, 3DS and Wii) aren’t really labeled “NintendoBrowser” in the UA itself, but they’re not really stock Opera or NetFront either, so I kept the “Nintendo Browser” name for them. Based on what I’ve seen in wikipedia and such, they’re typically named “DSi Browser” or something like that. I could change, if that makes more sense.

@codecov
Copy link

codecov bot commented Sep 27, 2017

Codecov Report

Merging #1599 into master will increase coverage by 0.03%.
The diff coverage is 70.58%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1599      +/-   ##
============================================
+ Coverage      46.4%   46.43%   +0.03%     
  Complexity      753      753              
============================================
  Files          1542     1544       +2     
  Lines         52538    52576      +38     
  Branches      21364    21381      +17     
============================================
+ Hits          24378    24414      +36     
- Misses        28160    28162       +2
Flag Coverage Δ Complexity Δ
#full 42.48% <70.58%> (+0.03%) 0 <0> (ø) ⬇️
#lite 1.55% <0%> (-0.01%) 0 <0> (ø)
#standard 23.89% <64.7%> (+0.04%) 0 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...owsers/access-netfront/access-netfront-nx-2-0.json 0% <ø> (ø) 0 <0> (ø) ⬇️
...user-agents/browsers/opera/opera-9-00-to-9-64.json 59.45% <ø> (-0.72%) 0 <0> (ø)
...owsers/access-netfront/access-netfront-nx-3-0.json 100% <ø> (ø) 0 <0> (ø) ⬇️
...gents/browsers/opera-mobile/opera-mobile-8-50.json 0% <ø> (-7.15%) 0 <0> (ø)
...rs/access-netfront/access-netfront-nx-generic.json 0% <ø> (-33.34%) 0 <0> (ø)
...rs/access-netfront/access-netfront-nx-3-1-3-5.json 60% <ø> (+5.45%) 0 <0> (ø) ⬇️
...sers/nintendo-browser/nintendo-browser-5-1-on.json 100% <100%> (ø) 0 <0> (?)
.../nintendo-browser/nintendo-browser-1-0-to-1-9.json 100% <100%> (ø) 0 <0> (?)
.../nintendo-browser/nintendo-browser-2-0-to-4-3.json 100% <100%> (ø) 0 <0> (?)
...ers/nintendo-browser/nintendo-browser-generic.json 61.53% <61.53%> (ø) 0 <0> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9851d75...1f50429. Read the comment docs.

@mimmi20 mimmi20 self-assigned this Sep 28, 2017
@mimmi20 mimmi20 added this to the 6025 milestone Sep 28, 2017
@mimmi20 mimmi20 merged commit 365154d into browscap:master Sep 28, 2017
@jaydiablo jaydiablo deleted the issue-1589 branch September 28, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants