Adding Nintendo Browser and Nintendo platforms #1599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1589
I moved the patterns for Nintendo devices to a single “Nintendo Browser” and made some versions from that. Also added platforms for all of the Nintendo devices (basically just match the platform). From what I can tell, Nintendo doesn’t really have any fancy names for their OSes like Sony does.
I collected all Nintendo related UAs I could find and ran them through these changes and made tests from any that added coverage.
The older browsers (like on the DS, 3DS and Wii) aren’t really labeled “NintendoBrowser” in the UA itself, but they’re not really stock Opera or NetFront either, so I kept the “Nintendo Browser” name for them. Based on what I’ve seen in wikipedia and such, they’re typically named “DSi Browser” or something like that. I could change, if that makes more sense.