Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate definitions #1839

Merged
merged 3 commits into from
May 3, 2018
Merged

remove duplicate definitions #1839

merged 3 commits into from
May 3, 2018

Conversation

mimmi20
Copy link
Member

@mimmi20 mimmi20 commented Mar 25, 2018

I added a check for duplicate definitions in the browsers, devices and useragent files. I removed the duplicates found by this check.

Fixes #1820.

@codecov
Copy link

codecov bot commented Mar 25, 2018

Codecov Report

Merging #1839 into master will increase coverage by 0.15%.
The diff coverage is 88.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1839      +/-   ##
============================================
+ Coverage     49.89%   50.04%   +0.15%     
- Complexity      758      764       +6     
============================================
  Files          1647     1647              
  Lines         59607    59462     -145     
  Branches      26496    26422      -74     
============================================
+ Hits          29741    29760      +19     
+ Misses        29866    29702     -164
Flag Coverage Δ Complexity Δ
#full 44.45% <87.5%> (+0.1%) 0 <0> (ø) ⬇️
#lite 2.11% <0%> (ø) 0 <0> (ø) ⬇️
#standard 25.76% <25%> (+0.05%) 0 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...rces/user-agents/browsers/omniweb/omniweb-5-6.json 0% <ø> (ø) 0 <0> (ø) ⬇️
...rces/user-agents/browsers/omniweb/omniweb-5-0.json 0% <ø> (ø) 0 <0> (ø) ⬇️
...ources/user-agents/crawlers/yandex/yandex-bot.json 75% <ø> (+15%) 0 <0> (ø) ⬇️
...rces/user-agents/browsers/firefox/firefox-3-0.json 48% <ø> (+0.63%) 0 <0> (ø) ⬇️
...rces/user-agents/browsers/omniweb/omniweb-5-9.json 0% <ø> (ø) 0 <0> (ø) ⬇️
...owsers/samsung/samsung-android-browser-6-2-on.json 68.3% <ø> (+0.73%) 0 <0> (ø) ⬇️
...r-agents/apps/facebook/facebook-messenger-app.json 93.77% <ø> (+0.22%) 0 <0> (ø) ⬇️
...ources/user-agents/browsers/iron/iron-generic.json 17.39% <ø> (+4.34%) 0 <0> (ø) ⬇️
...rces/user-agents/browsers/omniweb/omniweb-5-1.json 0% <ø> (ø) 0 <0> (ø) ⬇️
...rces/user-agents/browsers/omniweb/omniweb-5-5.json 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ff908...fee0f9e. Read the comment docs.

@mimmi20 mimmi20 added the bug label Mar 25, 2018
Copy link
Contributor

@jaydiablo jaydiablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over all of this and did confirm the duplicate removals all look appropriate (nice finds!).

I think the PHP changes, particularly to the Expander class, could use another pair of eyes though, @asgrim?

@mimmi20
Copy link
Member Author

mimmi20 commented May 1, 2018

@asgrim Do you have time to review this PR?

Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things I'd pick up, but for the sake of brevity LGTM :shipit:

@asgrim asgrim self-assigned this May 3, 2018
@asgrim asgrim added this to the 6.0.29 milestone May 3, 2018
@asgrim asgrim merged commit 6e13bb5 into browscap:master May 3, 2018
@mimmi20 mimmi20 deleted the issue-1820 branch May 3, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants