-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate definitions #1839
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1839 +/- ##
============================================
+ Coverage 49.89% 50.04% +0.15%
- Complexity 758 764 +6
============================================
Files 1647 1647
Lines 59607 59462 -145
Branches 26496 26422 -74
============================================
+ Hits 29741 29760 +19
+ Misses 29866 29702 -164
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked over all of this and did confirm the duplicate removals all look appropriate (nice finds!).
I think the PHP changes, particularly to the Expander class, could use another pair of eyes though, @asgrim?
@asgrim Do you have time to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor things I'd pick up, but for the sake of brevity LGTM
I added a check for duplicate definitions in the browsers, devices and useragent files. I removed the duplicates found by this check.
Fixes #1820.