Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Safari 11.1 (desktop) with tests #1852

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

jaydiablo
Copy link
Contributor

Fixes #1848

I searched for all cases of Safari 11.1 and only found these three useragents, which matches Apple’s docs about Safari 11.1: https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_11_1.html#//apple_ref/doc/uid/TP40014305-CH14-SW1

I moved 11.1 to its own file because of the CFNetwork patterns in the 11.0 file being version-less and because 11.1 is only available OSX 10.13, 10.12 and 10.11 anyhow.

I also looked at iOS to see if 11.1 needed to be added there, but like other versions of Safari, the x.1 versions don’t report that way on iOS (tested on my own phone which is on iOS 11.3).

@codecov
Copy link

codecov bot commented Apr 7, 2018

Codecov Report

Merging #1852 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1852      +/-   ##
============================================
+ Coverage     49.15%   49.16%   +<.01%     
  Complexity      758      758              
============================================
  Files          1642     1643       +1     
  Lines         59784    59789       +5     
  Branches      26704    26706       +2     
============================================
+ Hits          29389    29394       +5     
  Misses        30395    30395
Flag Coverage Δ Complexity Δ
#full 43.61% <80%> (ø) 0 <0> (ø) ⬇️
#lite 1.76% <80%> (ø) 0 <0> (ø) ⬇️
#standard 25.22% <80%> (ø) 0 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...urces/user-agents/browsers/safari/safari-11-0.json 35% <ø> (ø) 0 <0> (?)
...urces/user-agents/browsers/safari/safari-11-1.json 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afecccd...97291e3. Read the comment docs.

@mimmi20 mimmi20 self-assigned this Apr 7, 2018
@mimmi20 mimmi20 added this to the 6.0.29 milestone Apr 7, 2018
@mimmi20 mimmi20 merged commit ef507fc into browscap:master Apr 7, 2018
@jaydiablo jaydiablo deleted the issue-1848 branch April 7, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants