Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new pattern for new version of Snapchat on iOS #1893

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

jaydiablo
Copy link
Contributor

Fixes #1892

Added a new snapchat ios file for 10.33+. According to iTunes store, it still supports iOS 10.0+, so I didn't make any changes there (other than adding iOS 11.4).

Also added some versions to the <10.33 file, and iOS 11.4 to that one as well.

Tests added for coverage.

@jaydiablo jaydiablo requested review from asgrim and mimmi20 June 12, 2018 23:13
@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #1893 into master will decrease coverage by <.01%.
The diff coverage is 32%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1893      +/-   ##
============================================
- Coverage      50.1%   50.09%   -0.01%     
  Complexity      905      905              
============================================
  Files          1667     1668       +1     
  Lines         60890    60913      +23     
  Branches      26989    27001      +12     
============================================
+ Hits          30506    30513       +7     
- Misses        30384    30400      +16
Flag Coverage Δ Complexity Δ
#full 45.08% <32%> (-0.01%) 0 <0> (ø)
#lite 2.1% <0%> (-0.01%) 0 <0> (ø)
#standard 26.6% <4%> (-0.02%) 0 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
...es/user-agents/apps/snapchat/snapchat-generic.json 0% <0%> (ø) 0 <0> (ø) ⬇️
...-agents/apps/snapchat/snapchat-10-23-to-10-32.json 61.53% <100%> (ø) 0 <0> (?)
...s/user-agents/apps/snapchat/snapchat-10-33-on.json 53.84% <53.84%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d97622...03265f5. Read the comment docs.

@mimmi20 mimmi20 self-assigned this Jun 13, 2018
@mimmi20 mimmi20 added this to the 6.0.30 milestone Jun 13, 2018
@mimmi20 mimmi20 merged commit bae7d0b into browscap:master Jun 13, 2018
@jaydiablo jaydiablo deleted the issue-1892 branch June 13, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants