Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding iOS 12 and Safari 12 (both iOS and macOS) and macOS 10.14 #1895

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

jaydiablo
Copy link
Contributor

Fixes #1894.

Just a small sample of iOS 12 and Safari 12 UAs so far, but I added what I saw (plus adding iOS 12 to Chrome iOS as I figured that one would show up soon).

Tests added for coverage.

@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #1895 into master will decrease coverage by <.01%.
The diff coverage is 44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1895      +/-   ##
============================================
- Coverage      50.1%   50.09%   -0.01%     
  Complexity      905      905              
============================================
  Files          1667     1669       +2     
  Lines         60890    60937      +47     
  Branches      26989    27022      +33     
============================================
+ Hits          30506    30528      +22     
- Misses        30384    30409      +25
Flag Coverage Δ Complexity Δ
#full 45.08% <40%> (-0.01%) 0 <0> (ø)
#lite 2.12% <24%> (+0.01%) 0 <0> (ø) ⬇️
#standard 26.61% <22%> (-0.01%) 0 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
...ser-agents/browsers/chrome/chrome-ios-generic.json 66.66% <0%> (-3.93%) 0 <0> (ø)
...es/user-agents/browsers/safari/safari-generic.json 36.31% <0%> (ø) 0 <0> (ø) ⬇️
.../browsers/mobile-safari/mobile-safari-generic.json 38.94% <0%> (-3.59%) 0 <0> (ø)
.../user-agents/browsers/chrome/chrome-ios-48-on.json 88.46% <0%> (-7.38%) 0 <0> (ø)
...bile-safari-uiwebview/mobile-safari-uiwebview.json 61.53% <25%> (-1.98%) 0 <0> (ø)
...ser-agents/apps/listia-app/listia-app-generic.json 61.61% <50%> (-0.24%) 0 <0> (ø)
...ources/user-agents/apps/facebook/facebook-app.json 97.04% <50%> (-0.12%) 0 <0> (ø)
...r-agents/apps/facebook/facebook-messenger-app.json 93.57% <50%> (-0.21%) 0 <0> (ø)
...nts/browsers/mobile-safari/mobile-safari-12-0.json 70% <70%> (ø) 0 <0> (?)
...urces/user-agents/browsers/safari/safari-12-0.json 80% <80%> (ø) 0 <0> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d97622...1c51c1c. Read the comment docs.

@jaydiablo jaydiablo requested review from asgrim and mimmi20 June 13, 2018 02:06
@mimmi20 mimmi20 self-assigned this Jun 13, 2018
@mimmi20 mimmi20 added this to the 6.0.30 milestone Jun 13, 2018
@mimmi20 mimmi20 merged commit a5d81fd into browscap:master Jun 13, 2018
@jaydiablo jaydiablo deleted the issue-1894 branch June 13, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants