-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Android 9 and Essential Phone #1900
Conversation
resources/platforms.json
Outdated
@@ -3940,6 +3940,15 @@ | |||
"Platform_Version": "#MAJORVER#.#MINORVER#" | |||
} | |||
}, | |||
"Android_9_0": { | |||
"match": "*Linux*Android?9*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make sure there's a semicolon after the 9
here to weed out the spoofs (as discussed in #1896)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
===========================================
+ Coverage 50.09% 50.1% +<.01%
Complexity 905 905
===========================================
Files 1670 1670
Lines 60960 60976 +16
Branches 27034 27042 +8
===========================================
+ Hits 30535 30549 +14
- Misses 30425 30427 +2
Continue to review full report at Codecov.
|
Fixes #1896.