Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Android 9 and Essential Phone #1900

Merged
merged 2 commits into from
Jun 19, 2018
Merged

add Android 9 and Essential Phone #1900

merged 2 commits into from
Jun 19, 2018

Conversation

mimmi20
Copy link
Member

@mimmi20 mimmi20 commented Jun 18, 2018

Fixes #1896.

@mimmi20 mimmi20 added this to the 6.0.30 milestone Jun 18, 2018
@mimmi20 mimmi20 requested review from jaydiablo and asgrim June 18, 2018 18:32
@@ -3940,6 +3940,15 @@
"Platform_Version": "#MAJORVER#.#MINORVER#"
}
},
"Android_9_0": {
"match": "*Linux*Android?9*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make sure there's a semicolon after the 9 here to weed out the spoofs (as discussed in #1896)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #1900 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1900      +/-   ##
===========================================
+ Coverage     50.09%   50.1%   +<.01%     
  Complexity      905     905              
===========================================
  Files          1670    1670              
  Lines         60960   60976      +16     
  Branches      27034   27042       +8     
===========================================
+ Hits          30535   30549      +14     
- Misses        30425   30427       +2
Flag Coverage Δ Complexity Δ
#full 45.09% <88.88%> (+0.01%) 0 <0> (ø) ⬇️
#lite 2.11% <0%> (-0.01%) 0 <0> (ø)
#standard 26.59% <22.22%> (-0.01%) 0 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
...agents/browsers/chrome/chrome-android-generic.json 81.35% <0%> (-2.86%) 0 <0> (ø)
...r-agents/browsers/chrome/chrome-android-43-on.json 84.3% <100%> (+0.24%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d81fd...9fd831f. Read the comment docs.

@mimmi20 mimmi20 self-assigned this Jun 19, 2018
@mimmi20 mimmi20 merged commit 7dac7c0 into browscap:master Jun 19, 2018
@mimmi20 mimmi20 deleted the issue-1896 branch June 19, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants