Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Basilisk browser #1926

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Adding Basilisk browser #1926

merged 1 commit into from
Aug 22, 2018

Conversation

jaydiablo
Copy link
Contributor

Fixes #1925. This adds the basilisk browser as a "misc" browser with no versions.

I added the two UAs from #1925 as tests.

Windows versions come from their requirements page: https://www.basilisk-browser.org/requirements.shtml

I didn't have a Linux version of the UA to test, but figured it would be mostly the same to the windows version just with the linux style platform strings.

@mimmi20 mimmi20 self-assigned this Aug 22, 2018
@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #1926 into master will decrease coverage by <.01%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1926      +/-   ##
============================================
- Coverage     51.17%   51.17%   -0.01%     
  Complexity      905      905              
============================================
  Files          1673     1674       +1     
  Lines         59842    59855      +13     
  Branches      26151    26158       +7     
============================================
+ Hits          30624    30629       +5     
- Misses        29218    29226       +8
Flag Coverage Δ Complexity Δ
#full 46.08% <38.46%> (-0.01%) 0 <0> (ø)
#lite 2.14% <0%> (-0.01%) 0 <0> (ø)
#standard 26.92% <38.46%> (ø) 0 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
resources/user-agents/browsers/misc/basilisk.json 38.46% <38.46%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd63a53...5f75f9f. Read the comment docs.

@mimmi20 mimmi20 added this to the 6.0.31 milestone Aug 22, 2018
@mimmi20 mimmi20 merged commit 9a95bc9 into browscap:master Aug 22, 2018
@jaydiablo jaydiablo deleted the issue-1925 branch August 22, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants