Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new iOS Aloha Browser patterns #1932

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Conversation

jaydiablo
Copy link
Contributor

Fixes #1931

Added new patterns with tests to get all UAs I could find in our logs to detect as Aloha Browser instead of Safari.

@mimmi20 mimmi20 added this to the 6.0.31 milestone Aug 22, 2018
@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #1932 into master will increase coverage by <.01%.
The diff coverage is 70.58%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1932      +/-   ##
============================================
+ Coverage      51.2%   51.21%   +<.01%     
  Complexity      905      905              
============================================
  Files          1676     1676              
  Lines         59955    59989      +34     
  Branches      26202    26221      +19     
============================================
+ Hits          30701    30724      +23     
- Misses        29254    29265      +11
Flag Coverage Δ Complexity Δ
#full 46.11% <67.64%> (+0.01%) 0 <0> (ø) ⬇️
#lite 2.14% <0%> (-0.01%) 0 <0> (ø)
#standard 26.9% <44.11%> (ø) 0 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
resources/user-agents/browsers/aloha/aloha.json 81.17% <70.58%> (-9.02%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8055b74...cd6c602. Read the comment docs.

@mimmi20 mimmi20 self-assigned this Aug 22, 2018
@mimmi20 mimmi20 merged commit 7cf4342 into browscap:master Aug 22, 2018
@jaydiablo jaydiablo deleted the issue-1931 branch August 22, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants