Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1935
In addition to adding patterns for the UAs I saw being detected as Chrome, I also took the time to greatly improve the QQ Browser detection using historical UAs we've collected over the years that contained the QQ Browser identifiers (
QQ/
,MQQBrowser/
,QQBrowser/
) for all platforms.I've also split some of the files by version based on the patterns found in these UAs (in what versions were certain platforms or UA patterns "retired"). To help reduce the total number of patterns being added.
I've made tests out of all UAs possible to cover as many patterns as possible.
Over 7,500 UAs are now properly detected as QQ Browser with the expected platform/browser versions (many were being detected as IE/Netscape/Chrome/Safari).
I've also compared this branch to
master
on some recent collections of UAs and confirmed that the differences are all expected (correctly identifying QQ Browser and platform/browser versions).