Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ShopKeep App #1944

Merged
merged 1 commit into from
Sep 6, 2018
Merged

add ShopKeep App #1944

merged 1 commit into from
Sep 6, 2018

Conversation

mimmi20
Copy link
Member

@mimmi20 mimmi20 commented Sep 2, 2018

Is related to #1920.

@mimmi20 mimmi20 added this to the 6.0.31 milestone Sep 2, 2018
@codecov
Copy link

codecov bot commented Sep 2, 2018

Codecov Report

Merging #1944 into master will increase coverage by 0.01%.
The diff coverage is 69.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1944      +/-   ##
===========================================
+ Coverage     51.08%   51.1%   +0.01%     
  Complexity      905     905              
===========================================
  Files          1685    1687       +2     
  Lines         60551   60610      +59     
  Branches      26542   26569      +27     
===========================================
+ Hits          30933   30974      +41     
- Misses        29618   29636      +18
Flag Coverage Δ Complexity Δ
#full 46.02% <54.23%> (ø) 0 <0> (ø) ⬇️
#lite 2.12% <0%> (-0.01%) 0 <0> (ø)
#standard 26.88% <15.25%> (-0.02%) 0 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
...es/user-agents/apps/shopkeep/shopkeep-generic.json 0% <0%> (ø) 0 <0> (?)
resources/user-agents/apps/shopkeep/shopkeep.json 89.13% <89.13%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a39ecd...b84f379. Read the comment docs.

Copy link
Contributor

@jaydiablo jaydiablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to leave #1920 open to maybe add a more generic "native android app" pattern?

@mimmi20 mimmi20 self-assigned this Sep 6, 2018
@mimmi20 mimmi20 merged commit c20e3c4 into browscap:master Sep 6, 2018
@mimmi20 mimmi20 deleted the issue-1920 branch September 6, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants